elgg metadata unit tests has unnecessary code to remove metastrings

[cash]

Current unit tests leave behind > 150 metastrings in the metastrings table. Why have this code to try to clean up 2 of them?

Better to implement metastrings garbage collection

	protected function create_metastring($string) {
		global $CONFIG, $METASTRINGS_CACHE, $METASTRINGS_DEADNAME_CACHE;
		$METASTRINGS_CACHE = $METASTRINGS_DEADNAME_CACHE = array();

		mysql_query("INSERT INTO {$CONFIG->dbprefix}metastrings (string) VALUES ('$string')");
		$this->metastrings[$string] = mysql_insert_id();
	}

	protected function delete_metastrings() {
		global $CONFIG, $METASTRINGS_CACHE, $METASTRINGS_DEADNAME_CACHE;
		$METASTRINGS_CACHE = $METASTRINGS_DEADNAME_CACHE = array();

		$strings = implode(', ', $this->metastrings);
		mysql_query("DELETE FROM {$CONFIG->dbprefix}metastrings WHERE id IN ($strings)");
	}

[Cash Costello]

Fixes #3242 removed metastring clean up in one of the unit tests

Changeset: c58102ebcf60334f6902ba1df1aaee7104f6ba0d

[Cash Costello]

Fixes #3242 removed metastring clean up in one of the unit tests

Changeset: c58102ebcf60334f6902ba1df1aaee7104f6ba0d