Add option to limit the number of rotated log tables

[cash]

The current log rotation plugin takes the current system log table and copies it into an archive table. Site administrators then have to manually export/drop the tables. It would be better to work more like unix log rotation where an administrator can specify how many old logs to keep.

This requires adding a plugin setting (probably a drop down to select the number of old log tables to keep). We would also have to write a little SQL to get the table names that match <db_prefix>_system_log_*

[fierdor]

Will it be okay if I create another table "prefix"system_log_numbers where I will store an id and with it the value of $now()

For eg.

Id time_created
1 1300723597
2 1300723345
3 1300712597

Then when I need to delete I can just run a query to obtain "prefix"system_log_* to obtain the archived tables if they exceed the number of tables in the settings.
Like:
if count_of_rows(system_log_numbers) > number_of_archived_tables
delete system_log_* where *=time_created from system_log_numbers where id>number_of_archived_tables.

Is this design okay?

[cash]

You shouldn't need to create a table for this (and we prefer to not add any additional tables). Check out ​http://dev.mysql.com/doc/refman/5.5/en/show-tables.html

Something like "show tables like [elgg db prefix]system_log%" should work. Then parse the returned table names to get the dates.

[ashwanth]

@fierdor are you working on this Bug fix?

[cash]

Replying to ashwanth:

Yes, he's been on the #elgg IRC channel talking about it

[ashwanth]

Replying to cash:

Replying to ashwanth:

Yes, he's been on the #elgg IRC channel talking about it

Fine!

[fierdor]

Replying to ashwanth:

@fierdor are you working on this Bug fix?

Hey I am. I have put in a pull request. Waiting for review. Need to modify according to elgg coding standards.

[brettp]

Let's get this pull request in before we get out of sync.

[brettp]

(In [svn:9033]) Fixes #3253. Merged in Shashank's patch.