Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a print viewtype (Trac #3257) #3257

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 6 comments
Closed

Add a print viewtype (Trac #3257) #3257

elgg-gitbot opened this issue Feb 16, 2013 · 6 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3257 on 41237545-12-26 by cash, assigned to trac user blacktooth.

Elgg version: Github Master

The print viewtype should focus on presenting content in a way that is good for printing (black and white, no topbar, no sidebar?, focus on content). We can also add a printer icon to the extras menu (along with rss icon)

@elgg-gitbot
Copy link
Author

cash wrote on 41258155-06-14

A note on this one. You shouldn't have to copy all the views from the default viewtype to the print viewtype. Instead, register the print viewtype to fallback to default (see the function elgg_register_viewtype_fallback or something like that). Then you can selectively override views.

@elgg-gitbot
Copy link
Author

Attachment added by trac user blacktooth on 41273923-01-27: print_view.png

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41273923-12-05

I added the print icon to the extras menu. Now I tried creating an empty 'print' directory and added elgg_register_viewtype_fallback('print') to engine/lib/views.php
I couldn't see the blog posts properly using print view. When there are no views present in print/ , everything has to look like default view. But this is not happening.

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41295934-10-19

Done
https://github.com/blacktooth/Elgg/

@elgg-gitbot
Copy link
Author

brettp wrote on 41296585-11-03

Requires #3365.

@ewinslow
Copy link
Contributor

ewinslow commented Nov 6, 2014

I think printing is a pretty niche case that sites will want to have customized behavior for anyways. If we all the sudden get free cycles, we can revisit.

A more generally useful feature IMO would be a noscript option for older browsers (especially now that we have a much more aggressive browser support policy).

@ewinslow ewinslow closed this as completed Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants