Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull .elgg-text-help into core (Trac #3265) #3265

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Closed

Pull .elgg-text-help into core (Trac #3265) #3265

elgg-gitbot opened this issue Feb 16, 2013 · 7 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3265 on 41240326-09-03 by ewinslow, assigned to trac user blacktooth.

Elgg version: Github Master

Forms often have labels as well as further help text. Currently the developers plugin uses a class called .elgg-text-help to acheive this. This is a generally useful class and so should be moved into core -- main theme + admin theme.

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41250346-04-21

What is the best place to fit this in?
I am thinking of placing it in elements/helper.php

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41251266-01-12

I was thinking forms.php since it is meant to be help text for form input.

@elgg-gitbot
Copy link
Author

cash wrote on 41251311-03-12

Would it only be used in forms? How about typography.

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41251795-09-17

I think typography is a better place. I am placing it there.

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41252782-01-21

patched at gitgithub.com:blacktooth/Elgg.git

@elgg-gitbot
Copy link
Author

trac user blacktooth wrote on 41252961-08-08

patch updated, gitgithub.com:blacktooth/Elgg.git

@elgg-gitbot
Copy link
Author

cash wrote on 41255515-09-08

(In [svn:8932]) Refs #3265 pulled in blacktooth's commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant