We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3265 closed Enhancement (fixed)

Pull .elgg-text-help into core

Reported by: ewinslow Owned by: blacktooth
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@…, ravindhranath@… Difficulty: trivial

Description

Forms often have labels as well as further help text. Currently the developers plugin uses a class called .elgg-text-help to acheive this. This is a generally useful class and so should be moved into core -- main theme + admin theme.

Change History (8)

comment:1 Changed 2 years ago by blacktooth

  • Cc ravindhranath@… added
  • Component changed from Core to Developer Tools
  • Owner set to blacktooth

comment:2 Changed 2 years ago by blacktooth

  • Component changed from Developer Tools to Core

What is the best place to fit this in?
I am thinking of placing it in elements/helper.php

comment:3 Changed 2 years ago by ewinslow

I was thinking forms.php since it is meant to be help text for form input.

comment:4 Changed 2 years ago by cash

Would it only be used in forms? How about typography.

comment:5 Changed 2 years ago by blacktooth

I think typography is a better place. I am placing it there.

comment:6 Changed 2 years ago by blacktooth

  • Resolution set to fixed
  • Status changed from new to closed

patched at git@…:blacktooth/Elgg.git

comment:7 Changed 2 years ago by blacktooth

patch updated, git@…:blacktooth/Elgg.git

comment:8 Changed 2 years ago by cash

(In [svn:8932]) Refs #3265 pulled in blacktooth's commit

Note: See TracTickets for help on using tickets.