Class on menu items should include menu item name

[ewinslow]

e.g. a menu item named "like" in the "entity" menu would be like so:

<ul class="elgg-menu elgg-menu-entity">
    <li class="elgg-menu-item elgg-menu-item-like"></li>
</ul>

More themability control

[ewinslow]

(In [svn:9017]) Fixes #3282: Added a class to menu items which includes menu item name (just like ul contains a class with the menu name)

[ewinslow]

My "fix" only applies the name-based class when a class is manually passed. That's not very helpful...

[blacktooth]

Can the setItemClass() be modified so that when $optionsitem_class? is not set, it sets it to elgg-menu-item-$optionsname??

[blacktooth]

Can the setItemClass() be modified so that when $options['item_class']? is not set, it sets it to elgg-menu-item-$options['name']??

[ewinslow]

Yes, this is what I originally intended to do. Want to take care of it?

[blacktooth]

Replying to ewinslow:

Yes, this is what I originally intended to do. Want to take care of it?

Yeah!

[blacktooth]

I tried patching this, ​https://github.com/blacktooth/Elgg/commit/f63c7447c31dfc17585edecb0faede89900e95c2

[cash]

(In [svn:9200]) Fixes #3282 always using a menu item's name in its class

[cash]

I put blacktooth's code in the getItemClass method so all the logic would be in one place. Reopen if you think it should be in view.

[ewinslow]

Good solution, thanks for integrating that.