Opened 2 years ago
Closed 2 years ago
#3290 closed Enhancement (fixed)
Implement fluid gallery w/o tables
| Reported by: | ewinslow | Owned by: | ewinslow |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
http://blog.mozilla.com/webdev/2009/02/20/cross-browser-inline-block/
Inline-block to the rescue!
Change History (8)
comment:1 Changed 2 years ago by cash
comment:2 Changed 2 years ago by ewinslow
Fine with me!
comment:3 Changed 2 years ago by ewinslow
- Summary changed from Fluid grid w/o table to Implement fluid gallery w/o tables
comment:4 Changed 2 years ago by ewinslow
- Owner set to ewinslow
- Status changed from new to assigned
comment:5 Changed 2 years ago by ewinslow
Would this be a replacement for the table version of elgg-gallery, or simply the implementation of elgg-gallery-fluid? Other option of course is to just say that .elgg-gallery > li does one thing and .elgg-gallery td does another?
Furthermore, how do we want .elgg-gallery to work in terms of determining size (width) of items and spacing b/w them? .elgg-gallery-<size> ok? <size> being tiny, small, medium, or large? .elgg-gallery without a size class would be fully fluid (item content determines size of item).
comment:6 Changed 2 years ago by cash
I assumed this would replace the table implementation though maybe it is best to have both since one would only work with fixed width items.
I thought one of the points of this is that the gallery does not need to know anything about the width. That's the job of the content to define a fixed width.
For spacing, pick a decent default and then let people specify an additional class to change it if desired?
comment:7 Changed 2 years ago by ewinslow
OK, thanks for the feedback.
comment:8 Changed 2 years ago by ewinslow
- Resolution set to fixed
- Status changed from assigned to closed
(In [svn:9027]) Fixes #3290: Fluid gallery w/o tables -- working great for fixed-width content

Nice find! I think we should do this but without the FF2 support.