ECML needs work

[ncouture]

Problem:

Embedding a file in a file enabled group topic redirects you to the /action/file/upload URI and shows the following JSON message:

{"status":"error","message":"You must select a file"}

steps to recreate:

1. Create group with files enabled
2. Add a topic
3. Select (click) the "Embed content" link
4. Select (click) the "Upload media" tab
5. Highlight a file on your file system\
6. Select (click) the "Save" button

Tested on trunk (commit 842031dd358282f608c232094422cd281117c21f).

[ashleyward]

We were having this same error but all across the site.

I've attached some patches (one for elgg/trunk and one for plugins/trunk/ecml) which essentially do enough to get them working nicely in 1.8 - I haven't done an overhaul of the code (which I think it could probably do with at some point).

A summary of the changes is:

ECML Plugin:
============

• Updated some deprecated api calls
• Renamed admin/css view to just css (as it contained non-admin css too!)
• Updated the css styling slightly (instructions/preview togglers)
• Renamed blip.tv to blip_tv to match the sanitised class in the selector
• Switched it to use the textarea id rather than name to embed (to matche my changes to the embed plugin)

Embed Plugin
============

• Updated jQuery Form Plugin to latest (v2.73) which is compatible with jQuery 1.5 (the older one wasn't)
• Switched the plugin to use the texarea id rather than the textarea name (as there may be multiple textareas with the same name. Also the id was already available from the longtext menu but the name wasn't!). This will probably break other plugins which extend the embed plugin. I have updated ecml and tinymce also.
• Updated some styling to use the 1.8 standard styles

[ashleyward]

Patch to ECML plugin

[ashleyward]

Patch to Elgg trunk (for embed plugin)

[ashleyward]

Have noticed that the ecml plugin doesn't operate on group discussions for some reason. I'll have a look at that when I get some more spare time :)

[cash]

embed plugin is quite ugly. For reference we also have ticket #2911. I may be able to look at patches Thursday. If not, it would be next week.

[ashleyward]

No problem - no rush on my part. As I said I've done enough to get it working in 1.8, but I haven't really put any effort into updating the js or anything though.

There's also the problem of ecml not working on group discussions which I haven't had a chance to look at yet (I guess it's a simple fix).

[cash]

Nice job. The embed patch applied cleanly and everything worked. We're pulling this in for the next beta release of 1.8. I'm going to keep this ticket open as a ECML ticket after the commit.

[cash]

(In [svn:9134]) Refs #3360 updating the jquery form plugin

[cash]

(In [svn:9135]) Refs #3360 #2911 applying ashleyward's patch for embed plugin - thanks!

[cash]

Before a public release of ECML, we need to fix some things. Ashley's patch is a good start on that.