#3414 closed Defect (fixed)
bug in main view when switching https because bad regexp
| Reported by: | mandingo | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.7.9 |
| Component: | Core | Version: | 1.7 |
| Severity: | major | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
After enabling https login, and https apache support, and error is produced by this code:
default/account/forms/login.php:
$login_url = str_replace("http", "https", $vars['url']);
This generates an html that tryes to login into: httpss://whatever
Simply, change this code line to:
$login_url = str_replace("http:", "https:", $vars['url']);
and the problem will be fixed :)
Change History (4)
comment:1 Changed 2 years ago by ewinslow
- Milestone changed from Needs Review to Elgg 1.7.9
comment:2 Changed 2 years ago by brettp
- Resolution set to fixed
- Status changed from new to closed
(In [svn:9116]) Fixes #3414. Not rewriting http -> https if https login is enabled on a fully https server.
comment:3 Changed 2 years ago by brettp
That commit message is wrong. Not rewriting https -> httpss.
comment:4 Changed 2 years ago by brettp
(In [svn:9142]) Refs #3510, #3414, #3536. Ported https login fixes to trunk. Will need to backport changes to 1.7 for #3536.
Note: See
TracTickets for help on using
tickets.
The immediate fix is to turn off https login when your whole site is https, but you're right, this needs to get fixed.