elgg_count_comments() has incorrect use of plugin hook

[beck24]

Using the plugin hook comments:count, but presumably all plugin hooks.

When the function called by a plugin hook returns a value of (int)0 or (string)'0', the value is discarded and the original value is used. There doesn't appear to be any way to return 0 as a legitimate value. I've gotten around it by returning "<span>0</span>" so that it renders correctly on the page, but that's not ideal as another hook may want to perform other mathematical functions with the value.

[cash]

Thanks so much! We definitely appreciate it when people report these annoying little bugs.

It was some lazy code in elgg_count_comments() causing the problem. The fix will be included in Elgg 1.7.9

[cash]

(In [svn:9062]) Fixes #3433 correctly checking return value of plugin hook in elgg_count_comments() now

[brettp]

(In [svn:9139]) Refs #3510, #3433. Ported [svn:9062] to trunk. Fix for comment hook returning 0 comments.