elgg_format_attributes() does not support value = ''

[cash]

As an example, this breaks the advanced plugin sorting because all plugins = "" in the select. What happens is that the "" is dropped as the value do the string "All plugins" is passed as the category. This results in an empty page.

The issue is the call to is_not_null() returns false on "".

Evan wrote this and he is probably more aware of why is_not_null() was chosen. I tried switching it to !== null but that caused problems because false is passed for parameters like selected. Making it !== false && !== null seems to work for me so far.

[cash]

Evan, any thoughts on this one? Was stripping empty values done on purpose or by accident?

[ewinslow]

This may be a case where we were trying to be too helpful. IIRC, selected="" still means selected.

It also may have just been overly aggressive optimization on my part (if it's empty, why send down the attr at all?). I forget exactly.

Either way, I think it makes sense to include empty string attributes as just that. If someone needs otherwise they should use false or null.

[cash]

(In [svn:9102]) Fixes #3454 not stripping empty attributes