Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancybox CSS in IE < 9 (Trac #3461) #3461

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Closed

Fancybox CSS in IE < 9 (Trac #3461) #3461

elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3461 on 41375986-01-12 by trac user coldtrick, assigned to unknown.

Elgg version: 1.8 Beta

related to feature request #2882

Since we use alot of Fancybox in our different plugins we are pleased to see that Fancybox is integrated into Elgg 1.8.

However we encountered a CSS error in IE < 9 which could slowdown the webserver significantly. The CSS uses AlphaImageLoader and this can't handle relative url's.

Our fix is that we created a view fancybox\css with the CSS from fancybox and replaced all relative url's with absolute url's

@elgg-gitbot
Copy link
Author

brettp wrote on 41376938-04-01

How does this affect the server?

@elgg-gitbot
Copy link
Author

trac user coldtrick wrote on 41378047-03-24

as IE with AlphaImageLoader uses relative paths to the current url instead of the css file the images are loaded (for example) from profile/. since this are about 10 images the engine is loaded 10 time for one user, this causes the webserver to get increased load. Do this for 100 users with IE and it can overload the server.

Our experience: one webserver 230 concurrent users (80% IE). Server load 100%. We removed the fancybox css, 30%-40% server load. We replaced the CSS with the correct image url's => server load still 30%-40%

In IE9 this problem doesn't exist but if you turn on IE8 compatibility you can see (F12 -> network) which images are loaded for fancybox. You can see the paths being wrong.

@elgg-gitbot
Copy link
Author

trac user coldtrick wrote on 41378073-05-15

If you are moving the css to a view please also adjust the z-index of:
#fancybox-overlay to 9998
#fancybox-wrap to 9999

If in default Elgg CSS there are z-indexes which are higher, maybe fancybox should be a bit higher (or default Elgg a bit lower)

@elgg-gitbot
Copy link
Author

cash wrote on 41378542-12-07

Here is a thread on this: http://groups.google.com/group/fancybox/browse_thread/thread/8530478044b9f586

Possible solutions:

  • convert the css file to a view and insert the base url through php
  • runtime insertion of the base url through jQuery
  • pull the alpha loader stuff out into a ie6 fancybox css file and use condition includes so that it is only loaded for ie6
  • dump the alphaloader stuff from the css file completely (should work fine ie7 and up)
  • go back to an earlier version of fancybox (supposedly 1.2.6 works)
  • dump fancybox for colorbox

@elgg-gitbot
Copy link
Author

brettp wrote on 41378746-04-02

Since 1.8 only has C-level support for ie6, I'm all for dumping cruft that's required for ie6 and breaks everything else. Just the alphaloader stuff is only for images, Fancybox on ie6 should be as usable as the rest of the site without it.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.0 by cash on 41447775-05-31

@elgg-gitbot
Copy link
Author

trac user Brett Profitt wrote on 41662150-07-21

Fixes #3461: Using absolute URLs for lightbox CSS.
Changeset: e32bfa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant