New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml_to_object() is not GPL code (Trac #3468) #3468
Comments
brettp wrote on 41381596-06-29 Lovely. PHP's policy states code in comments are released under a CC license: http://www.php.net/license/index.php#doc-lic |
ewinslow wrote on 41500416-09-17 How's about we switch to SimpleXML? |
Milestone changed to |
trac user boroda wrote on 42202867-04-03 I have switched to SimpleXML in function xml_to_object(). Can you verified it? |
Attachment added by trac user boroda on 42208063-03-23: xml.php.patch |
trac user boroda wrote on 42208582-07-04 Tested under Elgg 1.8.1. |
brettp wrote on 42277540-10-14 Boroda - Thanks for the patch. We prefer Github pull requests if that is possible. |
Milestone changed to |
trac user boroda wrote on 42277554-10-28 Replying to brettp:
|
brettp wrote on 42277593-01-14 That's exactly how pull requests work! You fork it, make changes, then submit a pull request to elgg/elgg. More info: http://help.github.com/send-pull-requests/ |
trac user boroda wrote on 42277603-05-15 Replying to brettp:
|
trac user srokap wrote on 42580953-12-28 Please check pull request fixing this ticket: #348 |
Milestone changed to |
Milestone changed to |
brettp wrote on 42934485-03-13 Fixed in 6676577. |
Original ticket http://trac.elgg.org/ticket/3468 on 41381333-07-28 by cash, assigned to brettp.
Elgg version: Github Master
The text was updated successfully, but these errors were encountered: