brettp wrote on 41381596-06-29

Lovely. PHP's policy states code in comments are released under a CC license: http://www.php.net/license/index.php#doc-lic
This is not a software license, though, so I don't know the ramifications of apply that to software, of it can be. Might be best to rewrite it or contact the original author and ask him to license it GPL.

ewinslow wrote on 41500416-09-17

How's about we switch to SimpleXML?

http://php.net/manual/en/book.simplexml.php

Milestone changed to Elgg 1.9 by ewinslow on 41500416-09-17

trac user boroda wrote on 42202867-04-03

I have switched to SimpleXML in function xml_to_object(). Can you verified it?

Attachment added by trac user boroda on 42208063-03-23: xml.php.patch

trac user boroda wrote on 42208582-07-04

Tested under Elgg 1.8.1.

brettp wrote on 42277540-10-14

Boroda - Thanks for the patch. We prefer Github pull requests if that is possible.

Milestone changed to Elgg 1.9.0 by brettp on 42277540-10-14

trac user boroda wrote on 42277554-10-28

Replying to brettp:

Boroda - Thanks for the patch. We prefer Github pull requests if that is possible.
I didn't use Github before. I don't know how can I do that if I don't have access to change main brunch only what I can do it's create fork as I understand.

brettp wrote on 42277593-01-14

That's exactly how pull requests work! You fork it, make changes, then submit a pull request to elgg/elgg. More info: http://help.github.com/send-pull-requests/

trac user boroda wrote on 42277603-05-15

Replying to brettp:

That's exactly how pull requests work! You fork it, make changes, then submit a pull request to elgg/elgg. More info: http://help.github.com/send-pull-requests/
Thank's, I will try to do that.

trac user srokap wrote on 42580953-12-28

Please check pull request fixing this ticket: #348
Tested on version 1.8.3

Milestone changed to Elgg 1.8.10 by brettp on 42929036-05-11

Milestone changed to Elgg 1.8.12 by brettp on 42934480-07-19

brettp wrote on 42934485-03-13

Fixed in 6676577.