We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#3470 closed Enhancement (fixed)

Use rel=toggle instead of class=elgg-toggler

Reported by: ewinslow Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: JavaScript Version: 1.8 Beta
Severity: minor Keywords:
Cc: brett@… Difficulty: easy

Description

This seems more consistent with our other overloading of rel.

Change History (6)

comment:1 Changed 2 years ago by cash

Thoughts on this?

comment:2 Changed 2 years ago by ewinslow

I prefer the rel approach, but I guess that's clear from the fact that I submitted the ticket.

comment:3 Changed 2 years ago by brettp

I prefer rel, but only slightly. Consistency FTW.

comment:4 Changed 2 years ago by cash

  • Component changed from Core to JavaScript
  • Difficulty set to easy
  • Milestone changed from Needs Review to Elgg 1.8.0

rel it is

comment:5 Changed 2 years ago by brettp

Should we also switch the lightbox to rel=lightbox?

comment:6 Changed 2 years ago by Cash Costello

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #3470 using rel=toggle now

Changeset: 32387e6db0c56935e93314217b52eab4d9dca016

Note: See TracTickets for help on using tickets.