We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3487 closed Enhancement (worksforme)

nesting input/button in output/confirmlink or vice versa

Reported by: ismayil.khayredinov Owned by:
Priority: normal Milestone: Needs Review
Component: Core Version: 1.7
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

It would be great to modify output/confirmlink to accept html (not just text). E.g. it would be helpful to be able to wrap a button in this very handy view.

Change History (5)

comment:1 Changed 2 years ago by cash

  • Resolution set to worksforme
  • Status changed from new to closed

Sorry for taking so long to get back to you. You should be able to do this:

echo elgg_view('output/confirmlink', array(
    'href' => 'http://www.google.com',
    'text' => elgg_view('input/button', array(...));
    'text_encode' => false,
));

If you have a better suggestion or this doesn't work, please reopen and let's talk.

comment:2 Changed 2 years ago by ismayil.khayredinov

Your solution is true for 1.8, not 1.7

comment:3 Changed 2 years ago by cash

OK - we will need to decide whether to port the changes back to 1.7.x or not. I tend to not want to port it because you then up with a new feature. A plugin that uses the new feature works with 1.7.11 but not with 1.7.10 and before. It ends up giving developers more problems than it solves.

comment:4 Changed 2 years ago by ewinslow

I agree with Cash. If you really need it in 1.7, it's easy enough to override the view with the 1.8 code, I suppose.

Sidenote: is it really called "text_encode"? I think output/url is "encode_text", so I hope they're not different...

comment:5 Changed 2 years ago by ismayil.khayredinov

Sure, sounds reasonable. It's text_encode in confirmlink. Haven't looked at url.

Note: See TracTickets for help on using tickets.