Opened 2 years ago
Closed 2 years ago
#3508 closed Enhancement (fixed)
Backport plugin hook in add_to_river() from 1.8
| Reported by: | brettp | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.7.9 |
| Component: | Core | Version: | 1.7 |
| Severity: | trivial | Keywords: | |
| Cc: | brett@… | Difficulty: | trivial |
Description
Many modifications to core / plugin actions are to simply remove calls to add_to_river().
Change History (11)
comment:1 Changed 2 years ago by cash
comment:2 Changed 2 years ago by brettp
- Summary changed from Add plugin hook to add_to_river() to Backport plugin hook in add_to_river() from 1.8
Essentially. I was in 1.7 land and completely forgot about the changes you did for 1.8's river.
comment:3 Changed 2 years ago by brettp
For reference, this is #2402. Any objections to putting this in 1.7.9?
comment:4 Changed 2 years ago by brettp
- Milestone changed from Needs Review to Elgg 1.7.9
comment:5 Changed 2 years ago by brettp
- Resolution set to fixed
- Status changed from new to closed
(In [svn:9123]) Fixes #3508: Backported add, river plugin hook from 1.8
comment:6 Changed 2 years ago by cash
Where did you get the trunk revision from for the merge? The plugin hook should be 'creating', 'river'.
We had talked about following a pattern of 'creating' before and 'created' after to clear up confusion with the plugin hooks/events on creating objects and such. I decided it would be best to start using that with the river.
comment:7 Changed 2 years ago by brettp
- Resolution fixed deleted
- Status changed from closed to reopened
[svn:7877]. The only commit referenced on that ticket: http://trac.elgg.org/ticket/2402
I'll find the actual commit and update it.
comment:8 Changed 2 years ago by brettp
(In [svn:9124]) Refs #3508. Undoing previous commit. Will find the real commit for river plugin hook tomorrow.
comment:9 Changed 2 years ago by cash
oops - my fault then. [svn:9103]
comment:10 Changed 2 years ago by brettp
@Cash - Thanks for finding the commit. Trac's search isn't great...
comment:11 Changed 2 years ago by brettp
- Resolution set to fixed
- Status changed from reopened to closed
(In [svn:9127]) Fixes #3508. Pulled in the right commits to add a "creating", "river" hook for river entries.
Is this ticket to backport what we have done for 1.8 to 1.7?