We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#3563 closed Defect (fixed)

textarea in elgg.thewire.textCounter has to be jQuery object

Reported by: blacktooth Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: The Wire Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description


Change History (7)

comment:2 follow-up: Changed 2 years ago by cash

@blacktooth - is the current implementation not working?

comment:3 in reply to: ↑ 2 Changed 2 years ago by blacktooth

Replying to cash:

@blacktooth - is the current implementation not working?

It works for now as the live function sends 'this' (HTMLDOM Object) as parameter. It doesn't work if a jQuery object is passed as parameter to it. Using the function from a different context is not feasible. Like, passing $('#thewire-textarea') doesn't work.

comment:4 Changed 2 years ago by cash

I see. You should always post details on tickets for those of us who are a little slow with jQuery ;)

You closed the pull request. Are you planning on opening another one?

comment:5 Changed 2 years ago by blacktooth

Sure. I will do it from next time. ;)
I opened it again.

comment:6 Changed 2 years ago by cash

  • Component changed from Core to The Wire
  • Milestone changed from Needs Review to Elgg 1.8.0

comment:7 Changed 2 years ago by Cash Costello

  • Resolution set to fixed
  • Status changed from new to closed

Merge pull request #39 from blacktooth/thewire-counterfix

Fixes #3563 textarea has to be jQuery object

Changeset: 60d69e25433b7b00d9c7f20db43b71c8978560c9

Note: See TracTickets for help on using tickets.