We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 21 months ago

#3589 closed Defect (fixed)

JavaScript plugin hook handlers of type 'all' gets called twice

Reported by: blacktooth Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: JavaScript Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty: trivial

Description

Line 80, 82 in js/lib/hooks.js

Change History (4)

comment:1 Changed 2 years ago by cash

Funny, we had the same bug in the PHP code. I had to add special checks for 'all' when processing the hooks.

comment:2 Changed 23 months ago by ewinslow

  • Milestone changed from Needs Review to Elgg 1.8.x

comment:3 Changed 23 months ago by brettp

  • Milestone changed from Elgg 1.8.x to Elgg 1.8.0

I think this is important enough to fix for 1.8.0. The logic is already in the PHP code.

comment:4 Changed 21 months ago by Brett Profitt

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #3589. JS "all" hook handlers called only once.

Changeset: b1cbcfa842abf670c2b5805eb45bc8314836bb2d

Note: See TracTickets for help on using tickets.