Blog newpost translation

[DavidCB]

In mod\blog\start.php line 44:

register_notification_object('object', 'blog', elgg_echo('blog:newpost'));

It could be:

register_notification_object('object', 'blog', elgg_echo('blog:notify:newpost'));

And in the translation file add two lines:

Notifications

'blog:notify:newpost' => "New blog post",

That's all.
Excuse my English

[ewinslow]

Hi, David,

Thanks for the bug report! Is there a particular reason this language string needs to be changed?

[DavidCB]

Hi ewinslow,

You're welcome.

No, I just have based my change into another string that was in the wire and I found more explanatory.
There's no need to change the string

[cash]

Evan - a little history on the wire strings. They came from the JHU/APL version of the wire and we had our own notification system implementation called 'notify'. That's why the wire notification strings use that.

Long term, we will want separate strings for notifications because we'll want to say things like "New wire post by Evan Winslow" rather than the uninformative "New wire post".

[DavidCB]

Ok, but the really mistake is in the translation that not exist, not in the name of the string.
'blog:newpost' => "New blog post",

It appears in the inbox like "blog:newpost" when it should be say "New blog post"

Excuse my English

[cash]

Yes, we need to define 'blog:newpost'. Thanks for the report.

[cash]

Fixes #3593 defining the blog post notification string

Changeset: 43ac188ef47a45e6b711bbb9a624c9e9b21318d6