new menu system does not support more than one selected item

[vazco]

Currently when we have following menu structure:

parent [link1]

• child1 [link2]
• child2 [link3]
• child3 [link1]

if we go to link1, parent will be marked as selected (although child3 has the same link, it won't be selected). I think both links should be marked as selected instead.

[cash]

Need input on this: should the menu system support multiple select items (whether in a tree as described by Vazco or in a single section)?

Right now the menu builder only marks the first menu item it comes across that matches the requested URL as the selected item. The biggest change would be to the ElggMenuBuilder::getSelected() method. It would return an array rather than a single menu item.

[ewinslow]

I don't think we need to support multiple selected items, but I can see that in Vazco's case, it's definitely more intuitive for the child link to be selected, so we just need to be a bit smarter when finding the selected item.

[cash]

The issue is that we are finding the selected item before creating the tree. It is much easier to scan a list than crawl a tree. If we did it with the tree, we would keep track of depth and the deepest menu item would be selected. CSS could then be used to do the rest.