We have moved to Github. Please open tickets there.

Opened 23 months ago

Closed 11 months ago

#3633 closed Enhancement (wontfix)

Remove the system_message call from elgg.action

Reported by: blacktooth Owned by:
Priority: normal Milestone: Elgg 1.8.7
Component: JavaScript Version: Github Master
Severity: minor Keywords: gsoc-ajax
Cc: brett@… evan@… Difficulty: trivial

Description

The call to system_message can be removed from elgg.action and instead placed in $.ajaxSuccess() so that it will be triggered after every successful ajax request.

Change History (5)

comment:1 Changed 22 months ago by blacktooth

  • Keywords gsoc-ajax added

comment:2 Changed 20 months ago by brettp

  • Milestone changed from Needs Review to Elgg 1.8.x

I suppose the use case for calling a non-action and needing a system_message / register_error is hitting up invalid ajax views. This seems like a reasonable thing to do.

comment:3 Changed 16 months ago by cash

  • Milestone changed from Elgg 1.8.x to Elgg 1.8.5

comment:4 Changed 11 months ago by cash

  • Component changed from Core to JavaScript
  • Milestone changed from Elgg 1.8.6 to Elgg 1.8.7

comment:5 Changed 11 months ago by ewinslow

  • Resolution set to wontfix
  • Status changed from new to closed

I disagree with this approach. We know the format of ajax actions. We don't know it for arbitrary ajax requests.

Note: See TracTickets for help on using tickets.