Opened 23 months ago
Closed 23 months ago
#3642 closed Defect (fixed)
Likes river view is incomplete
| Reported by: | jtilson | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.0 |
| Component: | Likes | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: | trivial |
Description
Just thought I'd open a ticket about this (couldn't find an existing one)
Currently, it tries to create an annotation,and fails because the 'annotation/annotatelike' view doesn't exist..
add_to_river('annotation/annotatelike', 'likes', $user->guid, $entity->guid, "", 0, $annotation);
It should be 'river/annotation/likes/create'. This view has a @todo not finished, and just spits out the following on the river:
river:likes:object:file
or
river:likes:object:thewire, etc..
I suppose you just need to supply language strings, but that would mean a language string for each subtype.
Change History (7)
comment:1 Changed 23 months ago by cash
comment:2 Changed 23 months ago by jtilson
I'd prefer no likes in the river. We've got some 'like fanatics' that like everything they see, which definitely clogs up the stream.
comment:3 Changed 23 months ago by cash
- Difficulty set to trivial
- Milestone changed from Needs Review to Elgg 1.8.0
Same preference here. Someone could always add this to the river on their site with a small plugin if desired.
I'll remove the call to add river in the action and remove the incomplete view.
comment:4 Changed 23 months ago by ewinslow
Just for good measure, I'm also agreed that likes don't need to show up as separate activities in the river.
comment:5 Changed 23 months ago by ewinslow
I'd like to amend my opinion slightly: Likes are fine to show up in the river, but only if they get condensed. That is, I'm fine with the activity summary being "Evan likes this post", and even OK with a "like" floating a post to the top of the river, just not OK with 30 entries in a row of "<actor> likes <object>" if it's the same object.
So... likes in the river are theoretically acceptable, but as-is they are being presented as equally-weighty with every other activity, which shouldn't be the case. Easiest solution right now is to just remove them, but longer term I guess we'll just need a more sophisticated river.
comment:6 Changed 23 months ago by cash
There's ticket bouncing around (probably on 1.8.x) about trying to fix the condensed river work that was started in the riverdashboard plugin.
comment:7 Changed 23 months ago by Cash Costello
- Resolution set to fixed
- Status changed from new to closed
Fixes #3642 removing likes river code
Changeset: 0d956e1f0fb8ad6c009c217014984a3fc7c6e77f

Do you think we should put likes in the river? The concern that I have with this is that it could easily overwhelm other activity.