ewinslow wrote on 41517076-06-07

Yes, that seems silly. Perhaps would be good to have a elgg_register_meta function that adds arbitrary tags to the head?

Incidentally, this would be another good use case for the "page entity" concept -- since we could then register a "description" tag pretty easily.

brettp wrote on 41643406-06-11

Evan - Can you refresh my memory about the "page entity" concept?

This would actually work really well with the menu system's model, if it we hadn't pigeon-holed it only for menus...

ewinslow wrote on 41643631-07-12

page_entity was my idea for those pages whose main content is from a single entity in the system. page_owner is for contextual information (so we know to display a certain icon/menus in the sidebar or something). page_entity is also like that -- perhaps useful for displaying sidebar modules that have information/actions related to the entity currently on display (e.g. a blogpost).

It's not critical to this ticket by any means.

elgg_register_meta seems like a good idea to me -- allows us to do things like elgg_register_meta('description', $entity->excerpt) or whatever.

brettp wrote on 41650103-09-01

Well, I agree elgg_register_meta() is a good idea and went ahead and added it.

That said, the shortcut icon uses instead of a meta tag.

trac user Brett Profitt wrote on 41650159-04-13

Fixes #3662. Pulled out shortcut_icon to its own view for easier overriding.
Changeset: 647cadf

ewinslow wrote on 41651673-06-18

elgg_register_link? :)

brettp wrote on 41652799-01-18

JS and CSS are already there, so I did think about that. Right now I moved it out into its own view since I think it's probably the only non-JS or CSS use of link most people would use. Know of any more that might benefit from more rel = "whatever" registration functions?

brettp wrote on 41652799-08-26

I suppose we could just abstract out the elgg_register_external_file($type = "SHORTCUT ICON") then use the type as the rel param. Any consequences here?

ewinslow wrote on 41658872-08-09

elgg_register_link could also take over the RSS/Atom/JSON/FOAF alternate view registration that happens automatically.

I'll just say that I'd prefer the semantics to be more 1-1. any $type parameter should probably set the [type] attribute on whatever is being registered. Confusing for $type to set [rel].

cash wrote on 41727774-08-31

Discussion on this died out...do we want a new ticket on a general way to add links to support favicon, RSS, etc. in a more general way?

brettp wrote on 41727826-01-01

Yeup. #3851