#3700 closed Defect (fixed)
Need different names for items of profile action menu
| Reported by: | blacktooth | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.1b |
| Component: | Profile | Version: | Github Master |
| Severity: | minor | Keywords: | gsoc-ajax |
| Cc: | brett@… evan@… | Difficulty: | trivial |
Description
The Add Friend and Remove Friend items of profile action menu have the same name "addfriend", It would be better if they have different names.
Change History (7)
comment:1 Changed 22 months ago by blacktooth
comment:2 Changed 22 months ago by ewinslow
So this would be a good standard to get clear across the board: should this be done for like/unlike and join/leave as well? I'd vote yes, that in all these cases the menu items should have distinct names.
comment:3 Changed 22 months ago by blacktooth
- Keywords gsoc-ajax added
comment:4 Changed 21 months ago by brettp
- Milestone changed from Needs Review to Elgg 1.8.1
I think menu items should have unique names.
comment:5 Changed 20 months ago by cash
- Resolution set to fixed
- Status changed from new to closed
Fixes #3700 using different names for add friend and remove friend user hover menu items
Changeset: 25219468c2c0e76819a811fabf5d450ae425b79a
comment:6 Changed 20 months ago by brettp
- Milestone changed from Elgg 1.8.1 to Elgg 1.8.1b
comment:7 Changed 19 months ago by cash
Fixes #3700 using different names for add friend and remove friend user hover menu items
Changeset: 25219468c2c0e76819a811fabf5d450ae425b79a

https://github.com/blacktooth/Elgg/commit/899bce4e3b490fde4a631c338d70d394420b7164