set_plugin_setting() returns a guid instead of bool

[brettp]

Is there any reason to return the guid of the object the plugin setting is saved to? I expected it to be bool so did something like this:

$results = true;
$results &= set_plugin_setting(); // returned 1232
var_dump($results); // false.

That broke, but not on all sites and it took a while to track it.

[cash]

Wow, this is a mess. The original developers tended to return an id when saving anything (entity, private_setting, annotation, etc). The flow of functions backward is:

• set_plugin_setting()
• elgg_set_plugin_setting()
• ElggPlugin::setSetting()
• ElggPlugin::set()
• ElggEntity::setPrivateSetting()
• set_private_setting()

Along the way, there are inconsistencies in how return values are handled or when plugin hooks are fired.

[Cash Costello]

Fixes #3743 returning bool instead of int when setting a private setting

Changeset: c8bbc359656ced62de84511bb7bd8cb304609abb

[Cash Costello]

Fixes #3743 returning bool instead of int when setting a private setting

Changeset: c8bbc359656ced62de84511bb7bd8cb304609abb