Upgrading DB from 1.7 to 1.8 corrupts Discussions

[Tim_Bender]

A Discussion is comprised of an initial post (Title, Body, Tags) followed by a set of replies. After upgrading from 1.7 to 1.8 (beta) all of the Discussions had the Body removed from the initial post. The original post's Body was now shown as the content of the first reply.

Example:

---

In 1.7:

Initial post:
    Title - Cats
    Body - My cat puts his head in my sweaty shoe when I come home. Does your cat do funny things?
    Tags - Pets, Cats, lols
Reply #1:
    Body - lol, cats

---

After 1.8 upgrade:

Initial post:
    Title - Cats
    Body - 
    Tags - Pets, Cats, lols
Reply #1:
    Body - My cat puts his head in my sweaty shoe when I come home. Does your cat do funny things?
Reply #2:
    Body - lol, cats

[cash]

Brett - any comments on this?

[brettp]

Urm...no? I didn't write the discussion migration and haven't looked into the problem but can at some point.

[cash]

I just thought since you released 1.8.0 you would have looked at this

[brettp]

There are a lot of outstanding tickets that would have been nice to have looked at by someone, but none of us had the chance.

[cash]

Here's where we are on this:

• I wrote the upgrade script and tested it on a mirror of a reasonably large site (thousands of topics). It has also been tested on a mirror of the community site. Everything checked out and has been a part of the beta releases.
• We have had no other reports on this - from either the betas or the 1.8.0 release
• I just tested on a clean 1.7.11 to 1.8.0 upgrade and it did not create this problem

This could occur if you did not update the groups plugin when upgrading the site or had the groups plugin turned off. If you had it turned off, you should be able to turn it on, hit upgrade again, and have the groups upgrade run.

For more details see ​https://github.com/Elgg/Elgg/blob/master/mod/groups/upgrades/2011030101.php

The script tries to determine if the forum topics have already been upgrade. If not, it runs the upgrade. If this is on a production site, you'd need to rewrite the upgrade script since some topics have been created with the topic text on the object and some with have the topic text as an annotation.