forward() should throw Exception if headers were sent

[mrclay]

It's good that a couple gatekeepers throw exceptions if forward() returns false, but IMO the throw should occur in forward itself whenever headers were already sent.

I count 50+ usages of forward(); and in very few instances does the code check the return value. Even action_gatekeeper() doesn't. Authors expect--for better or for worse--that calling functions named "forward" or "redirect" will always halt program flow, and very small errors (outputting a newline in a PHP file) could break this contract.

[mrclay]

Pull request: ​https://github.com/Elgg/Elgg/pull/69

[Cash Costello]

Merge pull request #69 from mrclay/issue3765

Fixes #3765 forward throws Exception if headers sent.

Changeset: 26b56fb5d6d71bb56f03d0d4e999e09a1fc81476

[Cash Costello]

Merge pull request #69 from mrclay/issue3765

Fixes #3765 forward throws Exception if headers sent.

Changeset: 26b56fb5d6d71bb56f03d0d4e999e09a1fc81476