Opened 21 months ago
Closed 14 months ago
#3781 closed Defect (fixed)
User & group icons don't specify dimensions in HTML so page reformats dynamically on slow connections
| Reported by: | richardloxley | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.x |
| Component: | Core | Version: | 1.8 |
| Severity: | minor | Keywords: | user profile group icons size dimensions |
| Cc: | brett@… | Difficulty: |
Description (last modified by ewinslow)
The <img> tags for user profile and group icons don't contain 'width' and 'height' parameters. This means that the browser has to adjust the page layout as each image is downloaded and its size discovered.
This is particularly noticeable on slow connections when the list of groups is loaded.
I have a fix for this and will submit it through Github.
Change History (7)
comment:1 Changed 21 months ago by richardloxley
comment:2 Changed 20 months ago by cash
This is related to #1279
comment:3 Changed 20 months ago by cash
- Milestone changed from Needs Review to Elgg 1.8.1
comment:4 Changed 20 months ago by cash
- Owner set to cash
- Status changed from new to assigned
comment:5 Changed 19 months ago by cash
- Milestone changed from Elgg 1.8.1 to Elgg 1.8.2
Took a look at this. There is a problem with images smaller than the default sizes. It causes weird stretching artifacts. We could live with it and tell users to upload larger images, do upsampling on the images that are too small, or require images to be a certain size.
comment:6 Changed 18 months ago by cash
- Milestone changed from Elgg 1.8.2 to Elgg 1.8.x
- Owner cash deleted
- Status changed from assigned to new
comment:7 Changed 14 months ago by ewinslow
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
I believe this is resolved as of https://github.com/Elgg/Elgg/commit/5c991946ad52889d4b0511484d6a58f8898b5061.
Pull request sent in GitHub from surevine/Elgg:ticket3781