We have moved to Github. Please open tickets there.

Opened 21 months ago

Closed 21 months ago

Last modified 19 months ago

#3782 closed Defect (fixed)

deleteMetadata deleting all metadata

Reported by: vazco Owned by:
Priority: normal Milestone: Elgg 1.8.1b
Component: Core Version: 1.8
Severity: critical Keywords:
Cc: brett@… Difficulty: trivial

Description

Currently deleteMetadata don't check if entity we want to delete metadata from already exists. If it doesn't, guid is null. This deletes all metadata with given name (or all in case name is not passed) from all entities.

Change History (3)

comment:1 Changed 21 months ago by cash

  • Difficulty set to trivial
  • Milestone changed from Needs Review to Elgg 1.8.1b

Are you saying that you did this:

$object = new ElggObject();
$object->deleteMetadata();

That does look like a serious problem.

comment:2 Changed 21 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #3782 only deleting metadata if the entity has been saved

Changeset: 9097dd60953aa7f590a8de57c1c8302bf16beaef

comment:3 Changed 19 months ago by Cash Costello

Fixes #3782 only deleting metadata if the entity has been saved

Changeset: 9097dd60953aa7f590a8de57c1c8302bf16beaef

Note: See TracTickets for help on using tickets.