Opened 20 months ago
Closed 10 months ago
#3817 closed Defect (fixed)
Advanced site settings form breaks if admins using different languages
| Reported by: | cash | Owned by: | cash |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.9 |
| Component: | Core | Version: | 1.8 |
| Severity: | minor | Keywords: | admin, settings |
| Cc: | brett@…, sembrestels@… | Difficulty: |
Description (last modified by cash)
noticed this while fixing #3783
The value for the checkboxes is an elgg_echo'ed string so that if an another admin has a different default language, the settings that are enabled should appear like they are off. This will require an upgrade script to fix with the form using 0/1 or booleans instead of the strings.
Change History (6)
comment:1 Changed 18 months ago by cash
- Milestone changed from Needs Review to Elgg 1.8.x
comment:2 Changed 16 months ago by cash
- Milestone changed from Elgg 1.8.x to Elgg 1.8.5
comment:3 Changed 11 months ago by sembrestels
- Cc sembrestels@… added
- Keywords admin, settings added
- Owner set to sembrestels
- Status changed from new to assigned
comment:4 Changed 11 months ago by sembrestels
comment:5 Changed 10 months ago by cash
- Description modified (diff)
- Owner changed from sembrestels to cash
- Status changed from assigned to new
I'm going to clean up the use of strings.
comment:6 Changed 10 months ago by Cash Costello
- Resolution set to fixed
- Status changed from new to closed
Fixes #3817 cleans up advanced settings form
Changeset: 1ed326672a833f020bdb15f0b9cb047ab57f0b5b
Note: See
TracTickets for help on using
tickets.
Look at /actions/admin/site/update_advanced.php, all checkbox values are saved as booleans or as 0/1.
For example:
// allow new user registration? if (get_input('allow_registration', FALSE)) { set_config('allow_registration', TRUE, $site->getGUID()); } else { set_config('allow_registration', FALSE, $site->getGUID()); }I think in close this ticket as worksforme.