We have moved to Github. Please open tickets there.

Opened 20 months ago

Closed 20 months ago

Last modified 19 months ago

#3876 closed Defect (fixed)

navigation menu continues to show 'more' option

Reported by: JEBailey Owned by:
Priority: normal Milestone: Elgg 1.8.1b
Component: Core Version: 1.8
Severity: trivial Keywords:
Cc: brett@… Difficulty: trivial

Description

disable plugins that display in the navigation menu until you are down to one or two items.

Make sure that the configuration ( Configure > Menu items) has been set to display all items available in the navigation menu

The 'more' navigation menu option continues to be displayed even though there are no items beneath it.

The anticipated behavior would be that the 'more' option would not show up if empty.

Was able to achieve the anticipated behavior by modifying
Elgg/views/default/navigation/menu/site.php

I changed line 14 from

if (isset($varsmenu?more?)) {

to

if (!empty($varsmenu?more?)) {

Change History (3)

comment:1 Changed 20 months ago by cash

  • Difficulty set to trivial
  • Milestone changed from Needs Review to Elgg 1.8.1b

confirmed on the latest from Github

comment:2 Changed 20 months ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #3876 fixed dangling more site menu when items are manually selected - thanks to JEBailey

Changeset: 33d791bee34f1b2d5ae6b0c8e184c4bb1c00bc1a

comment:3 Changed 19 months ago by cash

Fixes #3876 fixed dangling more site menu when items are manually selected - thanks to JEBailey

Changeset: 33d791bee34f1b2d5ae6b0c8e184c4bb1c00bc1a

Note: See TracTickets for help on using tickets.