Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User avatar sizes differ from widget to widget (Trac #3907) #3907

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 20 comments
Closed

User avatar sizes differ from widget to widget (Trac #3907) #3907

elgg-gitbot opened this issue Feb 16, 2013 · 20 comments
Assignees

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3907 on 41751328-11-03 by trac user bchapin, assigned to unknown.

Elgg version: 1.8

Icon sizes range in size from widget to widget - in both the dashboard and group views.

@elgg-gitbot
Copy link
Author

cash wrote on 41751370-01-14

Do you have a screenshot of this?

@elgg-gitbot
Copy link
Author

Attachment added by trac user bchapin on 41751754-07-08: [Screen shot 2011-10-01 at 12.02.11 PM.png](http://trac.elgg.org/attachment/ticket/3907/Screen shot 2011-10-01 at 12.02.11 PM.png)

@elgg-gitbot
Copy link
Author

trac user bchapin wrote on 41751756-02-07

Attached file.

@elgg-gitbot
Copy link
Author

cash wrote on 41751786-10-22

OK - you are referring to the avatar sizes - I understand now

@elgg-gitbot
Copy link
Author

Title changed from Widget icon sizes differ from widget to widget to User avatar sizes differ from widget to widget by cash on 41751786-10-22

@elgg-gitbot
Copy link
Author

trac user bchapin wrote on 41751873-10-17

Right... avatars. I tend to lump them all under icons...

@elgg-gitbot
Copy link
Author

cash wrote on 41751905-08-23

Yeah, we introduced the term avatar in 1.8 to keep distinguish them - especially since we put a lot of time into having better support for icons.

@elgg-gitbot
Copy link
Author

trac user bchapin wrote on 41751918-12-14

Makes sense. Something about avatar reminds me of sci fi... in a bad way - but I'll adjust. So I am unfamiliar with what was added for better icon support. Can you enlighten me?

@elgg-gitbot
Copy link
Author

cash wrote on 41751959-12-04

Sure. We now have a set of sprites and you can use them like this: elgg_view_icon('delete')

There were other improvements but that is the main one. Before ever time you wanted to add an icon, it involved a lot of ugly cut and paste.

@elgg-gitbot
Copy link
Author

cash wrote on 42003759-05-15

Looks like this is mainly the activity widget using large user avatars. The pages and file plugin also may want to use a smaller version of their icons if one is available.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.4 by cash on 42003759-05-15

@elgg-gitbot
Copy link
Author

brettp wrote on 42067476-01-16

This inconsistency is a larger problem throughout the site--It's only mirrored here because of the object / river views. Do we:

  • Use the same size icons in widgets as the river / entity listing pages? (Makes /activity/ look a little cramped.)
  • Use smaller icons in widgets, and larger icons on listing pages? (Would require logic in views for context.)
  • Use small icons on widgets, and not care about the listing pages. (Less logic in views.)

@elgg-gitbot
Copy link
Author

brettp wrote on 42316755-04-02

Pushing this out to 1.8.5 since fixing the activity stream widget involves touching all the river views.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.5 by brettp on 42316755-04-02

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.12 by brettp on 42934480-07-19

@elgg-gitbot
Copy link
Author

trac user Brett Profitt <brett.profitt@... wrote on 42970391-09-22

In [changeset:"29606e1ecc874452f4d047a25e07755fcb7d7ac4/elgg"]:

#!CommitTicketReference repository="elgg" revision="29606e1ecc874452f4d047a25e07755fcb7d7ac4"
Refs #3907. Changed river icons to tiny size if used within a widget.

@elgg-gitbot
Copy link
Author

brettp wrote on 42970393-03-26

  • Files don't create a tiny size thumbnail.
  • Pages don't have a tiny size icon.
  • The Friends widget has a size setting.

I don't think these changes are appropriate for a bugfix release, so I've created tickets (#4967, #4966) for the other issues we can resolve in 1.9.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.9.0 by brettp on 42970393-10-20

@hypeJunction
Copy link
Contributor

Another easy one, removing from milestone.

@jdalsem jdalsem added this to the Elgg 3.0.x milestone Oct 10, 2016
@jdalsem jdalsem self-assigned this Nov 2, 2016
jdalsem added a commit to jdalsem/Elgg that referenced this issue Nov 1, 2017
@jdalsem
Copy link
Member

jdalsem commented Nov 9, 2017

Pages and Files have been fixed... the friends widget is a choice...

@jdalsem jdalsem closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants