We have moved to Github. Please open tickets there.

Opened 20 months ago

Last modified 5 months ago

#3907 new Defect

User avatar sizes differ from widget to widget

Reported by: bchapin Owned by:
Priority: low Milestone: Elgg 1.9.0
Component: Core Version: 1.8
Severity: trivial Keywords:
Cc: brett@… Difficulty: moderate

Description

Icon sizes range in size from widget to widget - in both the dashboard and group views.

Attachments (1)

Screen shot 2011-10-01 at 12.02.11 PM.png (309.7 KB) - added by bchapin 20 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 20 months ago by cash

Do you have a screenshot of this?

Changed 20 months ago by bchapin

comment:2 Changed 20 months ago by bchapin

Attached file.

comment:3 Changed 20 months ago by cash

  • Summary changed from Widget icon sizes differ from widget to widget to User avatar sizes differ from widget to widget

OK - you are referring to the avatar sizes - I understand now

comment:4 Changed 20 months ago by bchapin

Right... avatars. I tend to lump them all under icons...

comment:5 Changed 20 months ago by cash

Yeah, we introduced the term avatar in 1.8 to keep distinguish them - especially since we put a lot of time into having better support for icons.

comment:6 Changed 20 months ago by bchapin

Makes sense. Something about avatar reminds me of sci fi... in a bad way - but I'll adjust. So I am unfamiliar with what was added for better icon support. Can you enlighten me?

comment:7 Changed 20 months ago by cash

Sure. We now have a set of sprites and you can use them like this: elgg_view_icon('delete')

There were other improvements but that is the main one. Before ever time you wanted to add an icon, it involved a lot of ugly cut and paste.

comment:8 Changed 17 months ago by cash

  • Milestone changed from Needs Review to Elgg 1.8.4

Looks like this is mainly the activity widget using large user avatars. The pages and file plugin also may want to use a smaller version of their icons if one is available.

comment:9 Changed 16 months ago by brettp

This inconsistency is a larger problem throughout the site--It's only mirrored here because of the object / river views. Do we:

  • Use the same size icons in widgets as the river / entity listing pages? (Makes /activity/ look a little cramped.)
  • Use smaller icons in widgets, and larger icons on listing pages? (Would require logic in views for context.)
  • Use small icons on widgets, and not care about the listing pages. (Less logic in views.)

comment:10 Changed 13 months ago by brettp

  • Difficulty set to moderate
  • Milestone changed from Elgg 1.8.4 to Elgg 1.8.5
  • Priority changed from normal to low
  • Severity changed from minor to trivial

Pushing this out to 1.8.5 since fixing the activity stream widget involves touching all the river views.

comment:11 Changed 6 months ago by brettp

  • Milestone changed from Elgg 1.8.10 to Elgg 1.8.12

comment:12 Changed 5 months ago by Brett Profitt <brett.profitt@…>

In 29606e1ecc874452f4d047a25e07755fcb7d7ac4/elgg:

Refs #3907. Changed river icons to tiny size if used within a widget.

comment:13 Changed 5 months ago by brettp

  • Files don't create a tiny size thumbnail.
  • Pages don't have a tiny size icon.
  • The Friends widget has a size setting.

I don't think these changes are appropriate for a bugfix release, so I've created tickets (#4967, #4966) for the other issues we can resolve in 1.9.

comment:14 Changed 5 months ago by brettp

  • Milestone changed from Elgg 1.8.12 to Elgg 1.9.0
Note: See TracTickets for help on using tickets.