#3959 closed Enhancement (fixed)
Switch plugins to use elgg_release rather than elgg_version
| Reported by: | cash | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.1 |
| Component: | Core | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: | trivial |
Description
elgg_release is going to cause problems with parallel releases between 1.7 and 1.8. It is also confusing to the users.
Change History (6)
comment:1 Changed 19 months ago by brettp
comment:2 Changed 19 months ago by cash
I'm not saying that we should get rid of elgg_release. It definitely has its purpose. It's just that in 99% of the cases using a version will suffice. Using elgg_release also means nicer error messages to users ("You Elgg version needs to be greater than 2011647453 to run this plugin").
comment:3 Changed 19 months ago by brettp
So you're thinking prefer elgg_release, but use elgg_version if required?
comment:4 Changed 19 months ago by cash
exactly. I bet that every plugin on the community site just copied this line for another plugin so it ends up being meaningless. I've always found it to be a pain trying to track down the version number if my plugin supported 1.7.4 and above - for example.
comment:5 Changed 19 months ago by Brett Profitt
- Resolution set to fixed
- Status changed from new to closed
Fixes #3959. Using elgg_release in core plugins.
Changeset: f1be73852439f5eb7a9f6fdf1e9587f7b2346f69
comment:6 Changed 19 months ago by Brett Profitt
Fixes #3959. Using elgg_release in core plugins.
Changeset: f1be73852439f5eb7a9f6fdf1e9587f7b2346f69
Do we care about intra-dev releases? i.e. if we create a migration in master before 1.8.2 that the profile plugin depends on, with elgg_release we don't have the ability to say "only works on master > $date".