trac user tomv wrote on 41819270-09-13

Confirmed by us. Strange I did not see this after last embed changes of Cash... did we overlook or caused by something else ?

cash wrote on 41847669-10-19

This won't make it into 1.8.1

Milestone changed to Elgg 1.8.2 by cash on 41847669-10-19

trac user tomv wrote on 41920687-12-22

The bug is still in 1.8.1 as far as I can see. Suggest to call this 'major' ... it basically makes the whole Embed functionality useless, does it?

cash wrote on 41920768-11-04

It's assigned to the 1.8.2 milestone so yes, it is still there. Anyone can change severity on tickets I think.

cash wrote on 41948651-02-06

Current idea is to have the JavaScript switch from small to medium (or whatever) through some kind of find/replace. Long term, we need to add a UI to support selecting the size.

trac user tomv wrote on 41950468-12-03

Why did we not have this problem in 1.7? Find/Replace seems a little cumbersome?

Not sure if we really need size selector? TinyMCE can resize image if needed - Embed is little complicated for some users already...

cash wrote on 41950829-08-09

embed was rewritten for Elgg 1.8 and we got rid of some hacky code.

trac user Cash Costello wrote on 41961937-08-25

Refs #3971 inserting medium size thumbnails rather than small
Changeset: c97e17e

cash wrote on 41965810-03-27

Setting this to 1.8.x. We need a better UI and ECML to really fix this.

Milestone changed to Elgg 1.8.x by cash on 41965810-03-27

Milestone changed to Elgg 1.9.0 by cash on 42105621-10-09

Temporary work-around for #3971 is not working in elgg v2.2.3

The following javascript code in embed.js

			// this is a temporary work-around for #3971
			if (content.indexOf('thumbnail.php') != -1) {
				content = content.replace('size=small', 'size=medium');
			}

should be replaced by

			// this is a temporary work-around for #3971
			if (content.indexOf('serve-icon') != -1) {
				content = content.replace('small', 'medium');
			}

Closing the issue as #10711 fixed the bug. Other solutions for embedding are discussed elsewhere