#3976 closed Defect (fixed)
Make sure the JS normalize URL has the fix in #3747
| Reported by: | brettp | Owned by: | sembrestels |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.1 |
| Component: | JavaScript | Version: | 1.8.1b1 |
| Severity: | trivial | Keywords: | |
| Cc: | brett@… | Difficulty: | moderate |
Description
#3747 was to allow forward() to go to more than http and https. The JS solution will be more complicated because we're using filter_var() in PHP.
It's probably ok to push this one to 1.8.2 if needed.
Attachments (1)
Change History (14)
comment:1 Changed 19 months ago by Brett Profitt
comment:2 Changed 19 months ago by Purus
Hi,
Is this fixed and not closed? I could see a Changeset for this ticket.
comment:3 Changed 19 months ago by brettp
It hasn't been ported to the JS function.
comment:5 Changed 19 months ago by sembrestels
- Status changed from new to assigned
Changed 19 months ago by sembrestels
filter_var($url, FILTER_VALIDATE_URL) is calling php_filter_validate_url C function.
comment:6 Changed 19 months ago by sembrestels
There is no equivalent to filter_var function, but we can see what it is doing at C level.
comment:7 Changed 19 months ago by cash
Sem - take a look at the comments on this commit [518083ff5d13b6bec789bbdac03f4004b457c0ed]
comment:8 Changed 19 months ago by sembrestels
Pull requested. Here is the changeset: https://github.com/sembrestels/Elgg/commit/c466a2d2306011b18d7d5f9a1bca0eae5560f980
comment:9 Changed 19 months ago by Cash Costello
Merge pull request #88 from sembrestels/t3976
Refs #3976. Implements the fix for #3747 from PHP in elgg.normalize_url() js function.
Changeset: 12599e74e44cd9d2ee2c7dbc8b4950fd54aca789
comment:10 Changed 19 months ago by cash
- Resolution set to fixed
- Status changed from assigned to closed
Fixes #3976 fixed unit tests for normalizing urls and standardized the code from the previous merge
Changeset: 604a3bc06281de721e27561341299f1bb9f8ea51
comment:11 Changed 19 months ago by Brett Profitt
Refs #3927, #3976. Added elgg.parse_url() and elgg.parse_str().
Changeset: 518083ff5d13b6bec789bbdac03f4004b457c0ed
comment:12 Changed 19 months ago by Sem
Fixes #3976. elgg.normalize_url() js function has the fix in #3747.
Changeset: c466a2d2306011b18d7d5f9a1bca0eae5560f980
comment:13 Changed 19 months ago by Cash Costello
Merge pull request #88 from sembrestels/t3976
Refs #3976. Implements the fix for #3747 from PHP in elgg.normalize_url() js function.
Changeset: 12599e74e44cd9d2ee2c7dbc8b4950fd54aca789
Refs #3927, #3976. Added elgg.parse_url() and elgg.parse_str().