Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla fixes #4

Closed
wants to merge 11 commits into from
Closed

Vanilla fixes #4

wants to merge 11 commits into from

Conversation

hellekin
Copy link

@hellekin hellekin commented Jan 3, 2011

Only 4f84f26 and 9e2b31b are relevant at this point. I must have done something wrong again.

@hellekin
Copy link
Author

hellekin commented Jan 3, 2011

d19e428 removes thousands of E_NOTICEs when running tests with php_errors = E_ALL. It made me discover the otherwise invisible bug in 890c119. Now, only engine/tests/api/entity_getter_functions.php produces E_NOTICEs, but I didn't investigate further on how to fix them.

@cash
Copy link
Contributor

cash commented Jan 3, 2011

Most of these were included in your previous push which I think I merged in after you merged the Elgg master into your repo. It will be easier once we switch Elgg over it git rather than using it as a mirror.

@hellekin
Copy link
Author

hellekin commented Jan 3, 2011

Indeed. Only those I mentioned are to be considered.

@cash
Copy link
Contributor

cash commented Jan 6, 2011

I think all of those are integrated into our svn trunk (though with slightly different implementations). @ is equivalent to 2 ini_set calls as I understand it so I used isset() instead.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants