We have moved to Github. Please open tickets there.

Opened 19 months ago

Closed 13 months ago

#4009 closed Defect (fixed)

External pages should use walled garden theme for pages

Reported by: cash Owned by: cash
Priority: normal Milestone: Elgg 1.8.4
Component: External Pages Version: 1.8.2
Severity: minor Keywords:
Cc: brett@… Difficulty: moderate

Description (last modified by cash)

When a non-logged in user views the about, terms, and privacy page, they should be displayed with the walled garden theme. Otherwise, it feels like information is leaking out of the walled garden.

See #3947

Change History (8)

comment:1 Changed 18 months ago by cash

  • Milestone changed from Needs Review to Elgg 1.8.3

comment:2 Changed 17 months ago by Cash Costello

Refs #4009 registering the walled garden css and js on every request

Changeset: 1c2735807961ce916c27832327a07ef0bc9d5a40

comment:3 Changed 17 months ago by cash

  • Difficulty set to moderate
  • Version changed from Github Master to 1.8.2

The page shell, layout, forms need to be rewritten to allow other pages to use the walled garden shell/layout.

comment:4 Changed 17 months ago by cash

  • Milestone changed from Elgg 1.8.3 to Elgg 1.8.4

comment:5 Changed 16 months ago by Cash Costello

Refs #4009 registering the walled garden css and js on every request

Changeset: 1c2735807961ce916c27832327a07ef0bc9d5a40

comment:6 Changed 16 months ago by cash

  • Owner set to cash
  • Status changed from new to assigned

comment:7 Changed 13 months ago by cash

  • Description modified (diff)

I have a fix for this in a branch.

comment:8 Changed 13 months ago by brettp

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Cash's branch in ​https://github.com/Elgg/Elgg/commit/12e1aa2e380c6ea13251d2e626228483c4ab8da5

Note: See TracTickets for help on using tickets.