#4097 closed Defect (worksforme)
testElggEntityMetadata() test deprecated method
| Reported by: | andres.fortier | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Needs Review |
| Component: | Core | Version: | 1.8 |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
Elgg 1.8.0.1.
In tests/entities.php, method testElggEntityMetadata() tests the method clearMetaData() (lines 230, 239, 244, 248), which is marked as deprecated in elgg 1.8
Change History (4)
comment:1 Changed 18 months ago by cash
- Resolution set to worksforme
- Status changed from new to closed
comment:2 Changed 18 months ago by andres.fortier
Hi, I'm pretty new to the elgg ticket community, so forgive me if this is obvious, but I'm quite curious about the resolution. I know the test passes, but the test is currently checking a deprecated method which actually has its "right" counterpart. Why not change the test to use deleteMetadata() instead, which is the right method?
comment:3 Changed 18 months ago by cash
That's what the linked commit did. It was done after the 1.8.0 release so you did not see the fix. If you download 1.8.1 (just released yesterday) you should see this is fixed.
Maybe this link is better: https://github.com/Elgg/Elgg/commit/ba4bbf484d33fe24332ff63ac3b063f346a2a74c#L6R230
Thanks again for the tickets that you've been creating!
comment:4 Changed 18 months ago by andres.fortier
Oh, I'm sorry, I completely misunderstood the "worksforme" resolution! Thanks for the clarification.
I'm currently downloading 1.8.1, so I stay tuned with the last fixes.
Fixed in [ba4bbf484d33fe24332ff63ac3b063f346a2a74c]