We have moved to Github. Please open tickets there.

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#4113 closed Defect (fixed)

delete_access_collection() returns 1 on success instead of true.

Reported by: andres.fortier Owned by:
Priority: low Milestone: Elgg 1.8.2
Component: Core Version: 1.8.1
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

And the test cases go green due to the automatic (bool) casting. See for example tests/api/access_collections line 74 and 75:

$result = delete_access_collection($acl_id);
$this->assertTrue($result);

Change History (3)

comment:1 Changed 18 months ago by cash

  • Milestone changed from Needs Review to Elgg 1.8.2
  • Priority changed from normal to low

comment:2 Changed 18 months ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #4113 returning a bool from delete_access_collection()

Changeset: 3d975e028c3d5bde2ee8a5c9e09d7650b8f3c505

comment:3 Changed 18 months ago by cash

Fixes #4113 returning a bool from delete_access_collection()

Changeset: 337abf7ce0a68f4a2fe57036092c3188ba4f42f7

Note: See TracTickets for help on using tickets.