#4120 closed Defect (fixed)
Wrong return types check in testElggGetEntitiesFromMetadata()
| Reported by: | andres.fortier | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.2 |
| Component: | Core | Version: | 1.8.1 |
| Severity: | trivial | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
In line 61:
$this->assertTrue(create_metadata($this->object->guid, 'metaUnitTest', 'tested'));
create_metadata answers the guid of the new metadata. Maybe it could be tested for its type (int) and being greater than 0.
In line 65:
$this->assertFalse(elgg_get_entities_from_metadata($options));
elgg_get_entities_from_metadata() returns an empty array, not false.
Change History (3)
comment:1 Changed 18 months ago by cash
- Milestone changed from Needs Review to Elgg 1.8.2
- Priority changed from normal to low
comment:2 Changed 18 months ago by Cash Costello
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 18 months ago by Cash Costello
Fixes #4120 metadata tests now check for the correct types
Changeset: 53f140a4bd43e0f55765da30517b0d72d5e6da7d
Note: See
TracTickets for help on using
tickets.
Fixes #4120 metadata tests now check for the correct types