#4126 closed Defect (fixed)
Wrong assertion in entity_getter_functions.php passes due to type casting
| Reported by: | andres.fortier | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.2 |
| Component: | Core | Version: | 1.8.1 |
| Severity: | trivial | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
In line 2581:
$this->assertTrue(check_entity_relationship($fan_entity->guid, $relationship_name, $e->guid));
However check_entity_relationship() returns an object that represents the relationship. The test passes since the object is casted to a boolean (true).
Change History (3)
comment:1 Changed 18 months ago by cash
- Milestone changed from Needs Review to Elgg 1.8.2
- Priority changed from normal to low
comment:2 Changed 18 months ago by cash
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 18 months ago by cash
Fixes #4126 fixed test for checking relationship existence
Changeset: 77452e60a96e17f56e2bf7e88922d44f1fd7ef37
Note: See
TracTickets for help on using
tickets.
Fixes #4126 fixed test for checking relationship existence