'create' event trigger - create_entity vs create_object_entity

[ismayil.khayredinov]

Is there any particular reason to not call
elgg_trigger_event('create', $entity->type, $entity) in create_entity()?

It seems unreasonable inserting entity base information into the database and then deleting the entity if the event_handler says false. Perhaps it would be more rational to call elgg_trigger_event once in create_entity.

[cash]

When we trigger events/plugin hooks (and what we call them) needs to be reviewed. One thing we want to do in Elgg 1.9 is get away from having the data model classes calling functions. There is a lot of odd stuff like this:

function canEdit($user_guid = 0) {
    return can_edit_entity($this->getGUID(), $user_guid);
}

To your question, I think the goal is to wait until the object is fully created before triggering the event. We're thinking we need before/after events where the before is a plugin hook that lets you change/prevent the action. The after let's you know it happened.