We have moved to Github. Please open tickets there.

Opened 17 months ago

Closed 17 months ago

Last modified 16 months ago

#4228 closed Defect (fixed)

Groups: inconsistency in groups_sort_menu.php

Reported by: coldtrick Owned by:
Priority: normal Milestone: Elgg 1.8.3
Component: Groups Version: Github Master
Severity: minor Keywords: groups, sort menu
Cc: brett@… Difficulty:

Description (last modified by cash)

in mod/groups/views/default/groups/group_sort_menu.php line 26-28 the default selected tabs is determent.
However in the mod/groups/lib/groups.php line 17 & 55 this is already done.

This makes it very hard to have a different default selected tab.

i fixed this with the following code:

foreach ($tabs as $name => $tab) {
  $tab["name"] = $name;
		
  if($vars["selected"] == $name){
    $tab["selected"] = true;
  }
	
  elgg_register_menu_item("filter", $tab);
}

Change History (4)

comment:1 Changed 17 months ago by cash

  • Description modified (diff)

comment:2 Changed 17 months ago by cash

  • Milestone changed from Needs Review to Elgg 1.8.3

nice catch

comment:3 Changed 17 months ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #4228 group sort menu view accepts selected menu item from page handler

Changeset: c49f6d145700c878851ed6b548674d7693238841

comment:4 Changed 16 months ago by cash

Fixes #4228 group sort menu view accepts selected menu item from page handler

Changeset: c49f6d145700c878851ed6b548674d7693238841

Note: See TracTickets for help on using tickets.