Using checkboxes with widget settings

[coldtrick]

Before Elgg 1.8 is was possible to save widget settings which were an array. This was done by saving as metadata in case of an array.

A few widgets (in widget_manager plugin) use checkboxes as widget settings. This should be saved as an array. However in 1.8 this situation has changed. Saving an array is no longer possible as the "fallback" to metadata is no longer present. I would like to see it returned in 1.8.3, because we need this option.

[cash]

Here's the relevant code from Elgg 1.7 in save_widget_info():

if (is_array($value)) {
    // @todo Handle arrays securely
    $widget->setMetaData($name, $value, "", true);
} else {
    $widget->$name = $value;
}

New code from Elgg 1.8 in ElggWidget:saveSettings():

if (is_array($value)) {
    // private settings cannot handle arrays
    return false;
} else {
    $this->$name = $value;
}

This is related to #4072

[coldtrick]

Any progress? Would love to see it in 1.8.4

[ewinslow]

Can you submit a pull request? That'd be great. Thanks. Since this worked prior to 1.8, I think we can include it in the 1.8.x series.