Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A generic action throttler needed (Trac #4241) #4241

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 6 comments
Closed

A generic action throttler needed (Trac #4241) #4241

elgg-gitbot opened this issue Feb 16, 2013 · 6 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/4241 on 41978632-11-10 by trac user webgalli, assigned to unknown.

Elgg version: Github Master

A generic action throttler is needed for the system. To add a block to number of times an action can be attempted in a particular interval. For example 5 failed login attempts in 5 minutes, 10 password reset requests for a day.. etc. The solution is added to #116

@elgg-gitbot
Copy link
Author

cash wrote on 41978876-03-13

Is this for actions or a general throttle? The failed logins is not throttled based on any action.

@elgg-gitbot
Copy link
Author

trac user webgalli wrote on 41997847-09-04

Cash :The failed action throttle is already in use for login failures. The same function can be used as a generic action throttle or a failed action. We can use it for password reset requests (10 requests /24 hours as in the Giant sites like Fb, twitter etc), can save some server resource in case of a spambot hit.

Also we can use it for other actions like say a user can only send 10 invitations /day to his friends Or 10 private messages in 5 minutes, can post only 10 comments in 5 minutes etc. All we need is a proper working cron too.

Instead of duplicating the same function again, we can reuse it and keep the core light.

@elgg-gitbot
Copy link
Author

cash wrote on 42001348-08-01

No, the failed login throttle is not for actions. You can log in as many times as you want. It counts failed logins not the number of times you have logged in.

@elgg-gitbot
Copy link
Author

Title changed from A generic action throtller needed to A generic action throttler needed by cash on 42001348-08-01

@elgg-gitbot
Copy link
Author

Milestone changed to Long Term Discussion by ewinslow on 42363889-06-05

@ewinslow ewinslow removed this from the Discussion milestone Jul 6, 2014
@ewinslow
Copy link
Contributor

Do we really need to do anything here? As long as we have some kind of generic plugin hook when submitting forms, I think this should be done in a plugin... We already have the 'action,*' hook, so that should be though for now I would think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants