Opened 17 months ago
Last modified 17 months ago
#4244 new Defect
move upgrade logic out of views system
| Reported by: | ismayil.khayredinov | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Near Term Future Release |
| Component: | Core | Version: | 1.8.2 |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
Steps to replicated:
- overload page/upgrade.php in a plugin
- run upgrade.php
- remove page/upgrade.php
- attempt to run upgrade.php - white page, no error log, no activity
Change History (3)
comment:1 Changed 17 months ago by cash
- Milestone changed from Needs Review to Near Term Future Release
- Summary changed from upgrade fails if upgrade pageshell removed after being overloaded to move upgrade logic out of views system
comment:2 Changed 17 months ago by ismayil.khayredinov
- Version changed from 1.8.1 to 1.8.2
Also, should upgrade.php be only available to admins? Do we want users and non-loggedin users rebuilding cache?
comment:3 Changed 17 months ago by cash
What happens if a bad plugin prevents you from logging in? I think that's the logic behind this.
Most applications have you delete the upgrade script after you run it. We added a cache flush button in Elgg 1.8.2 so the upgrade script is not needed for that anymore.
Note: See
TracTickets for help on using
tickets.
I thought I already created a ticket for rewriting how upgrades are handled, but I guess I didn't. The current use of a page shell to forward to the upgrade script is a bad idea.
We need to make sure that the upgrade of the plugins in 1.8 does not break when we try to fix this. It uses a forward after completing to load the new plugin objects.