forward_url after login

[ismayil.khayredinov]

Can we add a config setting or a hook to override default forward_url for the login action?

[brettp]

The only reason not to is the pending events / hooks rewrite for 1.9.

I do see the use for this, though I definitely prefer a hook to a config setting.

[cash]

We need to develop guidance on when to use config settings and when to use hooks. Hooks offer more flexibility but have a higher overhead (more code to load and compile).

[ismayil.khayredinov]

After reading some of the questions related to this in the community, I must agree with Brett on using a hook. People want to do all kinds of things: forward on first login only, forward when xyz criteria is met etc.

[cash]

Do we implement this for 1.8.x or for 1.9?

[brettp]

1.9 is the target for the hooks rewrite. We made an exception for one hook because without it we couldn't properly support RSS. This hook would be a new feature, so I think it can wait. Please comment if anyone thinks we need more discussion.

[ismayil.khayredinov]

After looking at the code again, it looks like we don't really need a hook. We could just add another hidden input to the login form and use it in action as a forward url.

[cash]

Plugin hooks tend to be about changing how Elgg acts while views are about how Elgg looks. Because of that, I prefer the plugin hook over the view approach. What's the advantage of using the view?

[ismayil.khayredinov]

Ah, sorry I wasn't clear. I was thinking about a solution that could be introduced in 1.8 still.

[Cash Costello]

Fixes #4275 adds a login:forward, user hook - thanks to Ismayil

Changeset: daa9ce72199d6c354c874e94185f742a5bee8f2c

[hellekin]

Could that fix be integrated in 1.8.10?