Opened 17 months ago
Closed 16 months ago
#4276 closed Defect (fixed)
elgg_register_widget_type() - convert context parameter to array
| Reported by: | ismayil.khayredinov | Owned by: | ismayil.khayredinov |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.9.0 |
| Component: | Core | Version: | 1.8.2 |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
I don't really understand why not use an array instead of a comma-separated string for a list of contexts.
Change History (3)
comment:1 Changed 17 months ago by cash
- Milestone changed from Needs Review to Elgg 1.9.0
comment:2 Changed 17 months ago by ismayil.khayredinov
- Owner set to ismayil.khayredinov
Ok. Sounds good. I can work on that.
I am adding a bunch of tickets as I come accross things, so if you feel any of those do need to be fixed and are within my comprehension level, just give me a green light with your insight into how you would approach this. You can assign the tickets to me as well, that way I won't lost track of it :)
comment:3 Changed 16 months ago by Cash Costello
- Resolution set to fixed
- Status changed from new to closed
Merge pull request #142 from hypeJunction/widget_context_array
Fixes #4276 - elgg_register_widget_type() - replace a comma-separated list of contexts...
Changeset: 645de88ef99f267167029cc164f316325f8cb4b1
Note: See
TracTickets for help on using
tickets.
I agree. The original developers implemented it as a comma-separated string. That's just a bad idea. Why don't we queue this up for Elgg 1.9. Will need a catch for plugins still using strings and throw a deprecation notice.