#4339 closed Defect (fixed)
river uses subtype when creating summary strings - makes it difficult to create subtypes for user/groups
| Reported by: | cash | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.4 |
| Component: | Core | Version: | 1.8 |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description (last modified by cash)
Here is the code:
$action = $item->action_type;
$type = $item->type;
$subtype = $item->subtype ? $item->subtype : 'default';
...
echo elgg_echo("river:$action:$type:$subtype", array($subject_link, $object_link));
The problem is that when a user leaves a messageboard post and that user has a subtype like openid, the river string is 'river:messageboard:user:openid'. It's not reasonable to expect that plugins that create user subtypes, need to define every one of these type of strings.
Change History (5)
comment:1 Changed 16 months ago by cash
- Description modified (diff)
comment:2 Changed 13 months ago by Brett Profitt
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 12 months ago by Brett Profitt
Fixes #4339. Checking for river:$action:$type in addition to river:$action:$type:$subtype.
Changeset: 86a5bcf743143f301d0828931338de3ca59e25c7
comment:4 Changed 11 months ago by Cash Costello
Fixes #4339 for real this time - adds default for the subtype
Changeset: dbf78a975d2979ebeb50bd914b4ebc2c076ae09b
comment:5 Changed 11 months ago by Cash Costello
Fixes #4339 for real this time - adds default for the subtype
Changeset: dbf78a975d2979ebeb50bd914b4ebc2c076ae09b
Note: See
TracTickets for help on using
tickets.
Fixes #4339. Checking for river:$action:$type in addition to river:$action:$type:$subtype.