We have moved to Github. Please open tickets there.

Opened 16 months ago

Closed 11 months ago

Last modified 11 months ago

#4362 closed Defect (fixed)

group join request system is broken

Reported by: cash Owned by:
Priority: normal Milestone: Elgg 1.8.7
Component: Groups Version: 1.8.3
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

The link for managing requests is missing

Change History (9)

comment:1 Changed 16 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #4362 extra context was breaking group sidebar menu logic

Changeset: 488575ba727cf85f2da5c86513efa0307aaed894

comment:2 Changed 12 months ago by Cash Costello

Fixes #4362 extra context was breaking group sidebar menu logic

Changeset: 488575ba727cf85f2da5c86513efa0307aaed894

comment:3 Changed 11 months ago by coldtrick

why was this fixed like this?

You removed a feature from Elgg :(

Now if I want to only do stuff on the group profile page there is no way for me to know this.
Your problem could have been solved by checking if you where in the context "groups" (elgg_in_context("groups"))

comment:4 Changed 11 months ago by cash

This was 4 months ago - I don't remember why I did it this way.

comment:5 Changed 11 months ago by coldtrick

I know this was a long time ago.

I'm currently investigating some bug reports on my plugins and traced it back to this change.

How should I handle this, because (as I stated before) a feature of Elgg was removed?

comment:6 Changed 11 months ago by cash

  • Milestone changed from Elgg 1.8.4 to Elgg 1.8.7
  • Resolution fixed deleted
  • Status changed from closed to reopened

If we can fix the bug with something that does not break your plugin, we should do that. I'll reopen this and assign to 1.8.7. I'll have to go back and figure out why I chose this way to solve it. There may have been a good reason.

comment:7 Changed 11 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixes #4362 better solution to registering menu items for group pages

Changeset: 13dbb61c599254b6ff59c771fdb69b2641cd1d3d

comment:8 Changed 11 months ago by cash

  • Priority changed from high to normal

comment:9 Changed 11 months ago by Cash Costello

Fixes #4362 better solution to registering menu items for group pages

Changeset: 13dbb61c599254b6ff59c771fdb69b2641cd1d3d

Note: See TracTickets for help on using tickets.