We have moved to Github. Please open tickets there.

Opened 15 months ago

Closed 14 months ago

Last modified 14 months ago

#4392 closed Feature Request (wontfix)

Prevent disabling htmlawed

Reported by: mrclay Owned by:
Priority: normal Milestone: Needs Review
Component: Core Version: 1.8.3
Severity: minor Keywords: security
Cc: brett@… Difficulty:

Description (last modified by brettp)

Even with warnings, Elgg site admins simply do not consider how dangerous disabling htmlawed is, and I've seen other plugins and their docs mention "Oh, just turn htmlawed off then do this... and remember to turn it back on again!"

There should be one way to replace/disable its functionality: adding a plugin with a handler that bypasses it.

I see a couple BC options:

  1. Make a manifest option that prevents it from being disabled.
  2. Moved the plugin into libs while leaving its plugin hooks unchanged.

Change History (3)

comment:1 Changed 14 months ago by brettp

  • Description modified (diff)
  • Resolution set to wontfix
  • Status changed from new to closed

If we make it un-disable-able, the naughty plugins devs will update their docs to say "Delete mod/htmlawed." If we pull it into core they'll update their docs to say "Edit engine/lib/htmlawed.php and delete lines 10-700."

I don't think there's a good solution here. We can't FORCE admins to make the right choices any more than we can force 3rd party plugin devs to stop writing bad plugins. Ultimately it's up to the admin to know how to administer the site.

comment:2 Changed 14 months ago by mrclay

Ugh. Agreed.

comment:3 Changed 14 months ago by ewinslow

Btw, get_input has a third parameter that allows you to bypass the filter, so I think this is actually a worksforme issue.

Note: See TracTickets for help on using tickets.